Avoid allocating in pre_exec closure#337
Merged
appcypher merged 1 commit intozerocore-ai:mainfrom Nov 21, 2025
Merged
Conversation
Member
|
@purplesyringa Can you extend ur fix to these lines as well: microsandbox/microsandbox-utils/lib/runtime/supervisor.rs Lines 129 to 131 in 0d99770 |
Contributor
Author
|
Isn't that the exact same location? |
Member
|
you are right. |
appcypher
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error::newallocates memory (see rust-lang/rust#148971). This is bad in multi-threaded programs, which microsandbox AFAIK is. If the fork occurs while the allocator lock is held by another thread, deadlocks can occur, since there's no one left in the new process to unlock the mutex. I do not believe this is UB, and modern libc offer protections against this issue, but this isn't POSIX-compliant and should preferably be avoided.I've found two other places where
setsidare invoked, and there it's called throughlibc, ignoring the resulting error (which should be impossible in a new process anyway). I adjusted the third place to use the same pattern.